[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252537#comment-13252537
 ] 

Ted Yu commented on HBASE-5604:
-------------------------------

If you run the patch through 'arc lint', you would see (just excerpt):
{code}
   Warning  (TXT3) Line Too Long
    This line is 106 characters long, but the convention is 100 characters.

             274     System.err.println("  -D" + BULK_OUTPUT_CONF_KEY + 
"=/path/for/output");
             275     System.err.println("  (Exactly one table must be specified 
for this option, and not mapping can be specified!)");
             276     System.err.println("Other options:");
    >>>      277     System.err.println("  -D" + HLogInputFormat.START_TIME_KEY 
+ "=ms (only apply edit after this time)");
             278     System.err.println("  -D" + HLogInputFormat.END_TIME_KEY + 
"=ms (only apply edit before this time)");
             279     System.err.println("For performance also consider the 
following options:\n"
             280         + "  -Dmapred.map.tasks.speculative.execution=false\n"

   Warning  (TXT3) Line Too Long
    This line is 105 characters long, but the convention is 100 characters.

             275     System.err.println("  (Exactly one table must be specified 
for this option, and not mapping can be specified!)");
             276     System.err.println("Other options:");
             277     System.err.println("  -D" + HLogInputFormat.START_TIME_KEY 
+ "=ms (only apply edit after this time)");
    >>>      278     System.err.println("  -D" + HLogInputFormat.END_TIME_KEY + 
"=ms (only apply edit before this time)");
             279     System.err.println("For performance also consider the 
following options:\n"
             280         + "  -Dmapred.map.tasks.speculative.execution=false\n"
             281         + "  
-Dmapred.reduce.tasks.speculative.execution=false");
{code}
Below is a long line:
{code}
+        throw new IOException(option + " must be specified either in the form 
2001-02-20T16:35:06.99 or as a number of milliseconds");
{code}
Minor comment: the 'a' in 'as a number' should be omitted.
                
> M/R tool to replay WAL files
> ----------------------------
>
>                 Key: HBASE-5604
>                 URL: https://issues.apache.org/jira/browse/HBASE-5604
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 5604-v4.txt, 5604-v6.txt, 5604-v7.txt, 5604-v8.txt, 
> 5604-v9.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to