Apache9 commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL
flag does not work on branch-2.x
URL: https://github.com/apache/hbase/pull/974#discussion_r362363283
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -577,10 +577,9 @@ public void run() {
//TraceScope scope = Trace.continueSpan(takeSyncFuture.getSpan());
long start = System.nanoTime();
Throwable lastException = null;
- boolean wasRollRequested = false;
try {
TraceUtil.addTimelineAnnotation("syncing writer");
- writer.sync(useHsync);
+ writer.sync(takeSyncFuture.isForceSync());
Review comment:
Since you can change the durability by mutation, you can not use different
WALs for different mutations for the same region? But anyway, you can implement
a multi wal strategy to use different WALs for different durability levels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
