belugabehr commented on issue #977: HBASE-23628: Remove Apache Commons Digest Base64 URL: https://github.com/apache/hbase/pull/977#issuecomment-570226983 @saintstack Hello and thank you for the review! Yes. The two create the same output. Since you pushed back on that (rightfully), I just wrote a small test suite to increase my confidence on that. I generated many tens of millions of random byte patterns and compared the output of the two algorithms. They came back identical every time. Just in case any inquiring minds would like to know, there is no longer an encoding required when generating the strings. The JDK implementation specifically specifies that strings returned are `StandardCharsets.ISO_8859_1`. This does not change anything because UTF8 and ISO_8859 overlap for the limited character set (64 characters) the encoding uses.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
