saintstack commented on a change in pull request #762: HBASE-23157 WAL
unflushed seqId tracking may wrong when Durability.AS…
URL: https://github.com/apache/hbase/pull/762#discussion_r362704972
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WAL.java
##########
@@ -193,10 +193,12 @@ default void sync(long txid, boolean forceSync) throws
IOException {
/**
* Complete the cache flush.
* @param encodedRegionName Encoded region name.
+ * @param maxFlushedSeqId The maxFlushedSeqId for this flush. There is no
edit in memory that is
Review comment:
Or dang, its fine. Ignore this comment. Its a nit and I had it wrong-way
around thinking it the smallest edit flushed (wrong).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
