BukrosSzabolcs commented on a change in pull request #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r362806887
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -478,6 +478,10 @@ void checkForErrors() throws IOException {
throw new RuntimeException(thrown);
}
}
+
+ public Throwable clearError(){
+ return thrown.getAndSet(null);
+ }
Review comment:
Not just cleaner it would also cover more usecases. I moved that line into
the checkForErrors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
