anoopsjohn commented on a change in pull request #948: HBASE-23588 : Cache
index & bloom blocks on write if CacheCompactedBl…
URL: https://github.com/apache/hbase/pull/948#discussion_r363027397
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1120,9 +1120,25 @@ public StoreFileWriter createWriterInTmp(long
maxKeyCount, Compression.Algorithm
if (isCompaction) {
// Don't cache data on write on compactions, unless specifically
configured to do so
writerCacheConf = new CacheConfig(cacheConf);
-
writerCacheConf.setCacheDataOnWrite(cacheConf.shouldCacheCompactedBlocksOnWrite());
+ final boolean shouldCacheCompactedBlocksOnWrite = cacheConf
Review comment:
Sorry for being late here.
The var name here sounds like a method name. Ideally it should be a noun.
'cacheCompactedBlocksOnWrite'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
