[ 
https://issues.apache.org/jira/browse/HBASE-23648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009206#comment-17009206
 ] 

Bharath Vissapragada commented on HBASE-23648:
----------------------------------------------

Oops, thats a valid point. In that case, it should always be tied to the 
lifecycle of a connection I guess (which the code does in most places). One 
obvious deviation from this is RawAsyncHBaseAdmin, that needs to be fixed.

> Evaluate making ConnectionRegistry a singleton class
> ----------------------------------------------------
>
>                 Key: HBASE-23648
>                 URL: https://issues.apache.org/jira/browse/HBASE-23648
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 3.0.0
>            Reporter: Bharath Vissapragada
>            Assignee: Bharath Vissapragada
>            Priority: Major
>
> Based on the discussion between [~stack] and I in the code review for 
> HBASE-23305, the current usage of ConnectionRegistry is ad-hoc, sometimes 
> multiple times per connection.
> I don't see any obvious reason to not make it a singleton (except for 
> testing). This makes it more readable. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to