JeongDaeKim commented on a change in pull request #980: HBASE-23205 Correctly
update the position of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/980#discussion_r363610534
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -727,8 +740,7 @@ protected void shipEdits(WALEntryBatch entryBatch) {
}
private void updateLogPosition(long lastReadPosition) {
- manager.setPendingShipment(false);
Review comment:
Yes, we don't need the flag anymore. it was required because not only
shipper but also reader thread can update log position, but it had some issues
about concurrency and high update frequency. With this PR, when wal rolled or
log position changed, reader will put a batch for shipper to update log
position.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
