bharathv commented on a change in pull request #995: HBASE-23055 Alter 
hbase:meta
URL: https://github.com/apache/hbase/pull/995#discussion_r364418226
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java
 ##########
 @@ -128,4 +130,42 @@ public void testNoMetaAvailable() throws 
InterruptedException {
       }
     }
   }
+
+  /**
+   * Test meta tablestate implementation.
+   * Test is a bit involved because meta has replicas... Replica assign lags 
so check
+   * between steps all assigned.
+   */
+  @Test
+  public void testMetaTableState() throws IOException, ExecutionException, 
InterruptedException {
+    assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster().isActiveMaster());
+    while (!TEST_UTIL.getMiniHBaseCluster().getMaster().isInitialized()) {
 
 Review comment:
   q: Isn't this guaranteed by startMiniCluster()? It doesn't return until 
there is an active initialized master and it can scan meta. If so, can be 
omitted?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to