[ 
https://issues.apache.org/jira/browse/HBASE-23569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013991#comment-17013991
 ] 

Andrew Kyle Purtell commented on HBASE-23569:
---------------------------------------------

Since we rarely use integration tests I definitely meant unit test when filing 
this.

Yes, the essential thing to test is all of the expected chores - especially the 
log cleaner - are running after the master initializes. If you want to fold 
this in to a more general change that checks all of the default chores that 
would cover it. 

> Validate that the log cleaner actually cleans oldWALs as expected
> -----------------------------------------------------------------
>
>                 Key: HBASE-23569
>                 URL: https://issues.apache.org/jira/browse/HBASE-23569
>             Project: HBase
>          Issue Type: Test
>          Components: integration tests, master, test
>            Reporter: Andrew Kyle Purtell
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> The fix for HBASE-23287 (LogCleaner is not added to choreService) is in but 
> we are lacking test coverage that validates that the log cleaner actually 
> cleans oldWALs as expected. Add the test. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to