joshelser commented on a change in pull request #884: HBASE-23347 Allowable
custom authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#discussion_r366113087
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/AbstractHBaseSaslRpcClient.java
##########
@@ -59,73 +47,47 @@
/**
* Create a HBaseSaslRpcClient for an authentication method
- * @param method the requested authentication method
+ * @param conf the configuration object
+ * @param provider the authentication provider
* @param token token to use if needed by the authentication method
- * @param serverPrincipal the server principal that we are trying to set the
connection up to
+ * @param serverAddr the address of the hbase service
+ * @param securityInfo the security details for the remote hbase service
* @param fallbackAllowed does the client allow fallback to simple
authentication
* @throws IOException
*/
- protected AbstractHBaseSaslRpcClient(AuthMethod method, Token<? extends
TokenIdentifier> token,
- String serverPrincipal, boolean fallbackAllowed) throws IOException {
- this(method, token, serverPrincipal, fallbackAllowed, "authentication");
+ protected AbstractHBaseSaslRpcClient(Configuration conf,
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
