ndimiduk commented on a change in pull request #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#discussion_r366520024
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerRetriableFailure.java ########## @@ -68,7 +68,7 @@ private static final String FAMILY_NAME_STR = "f"; private static final byte[] FAMILY_NAME = Bytes.toBytes(FAMILY_NAME_STR); - @Rule public TestTableName TEST_TABLE = new TestTableName(); + @Rule public TableNameTestRule TEST_TABLE = new TableNameTestRule(); Review comment: Also not yours, but this variable is not `static` and its name really as no business being SCREAM_CASE. Bleh. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
