joshelser commented on issue #966: HBASE-23620 KeyPrefixRegionSplitPolicy may cause split to fail when s… URL: https://github.com/apache/hbase/pull/966#issuecomment-574802297 > Leaving it as it is now, where it's completely breaking split seems the worse option to me. > But for KPRSP, I think it should at least apply the validation and throw an exception if it can't get a valid split point, other than leaving the procedure moving forward and failing further to perform the split. So, I can see the exception on Jira, but how does this manifest? Is this a side-effect of pv2 where the split procedure just keeps getting retried? Is it a simple thing for a SplitPolicy to "defer" making a split when we detect the case where we'd generate an invalid split point? Agree with Duo that we can't change KPRSP's default functionality as that could seriously break users. I could see a new SplitPolicy which encapsulates your change, Wellington.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
