binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when 
disable DeadServerMetricRegionChore
URL: https://github.com/apache/hbase/pull/1026#discussion_r367203725
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 ##########
 @@ -1378,7 +1378,9 @@ public void joinCluster() throws IOException {
 
     // Start the chores
     master.getMasterProcedureExecutor().addChore(this.ritChore);
-    master.getMasterProcedureExecutor().addChore(this.deadMetricChore);
+    if (this.deadMetricChore != null) {
 
 Review comment:
   I know it can  be removed,  add it to show just where is wrong actually and 
cause the problem. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to