Apache9 commented on a change in pull request #1048: HBASE-23694 After
RegionProcedureStore completes migration of WALProcedureStore, …
URL: https://github.com/apache/hbase/pull/1048#discussion_r367260757
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##########
@@ -364,6 +364,7 @@ public void handleCorrupted(ProcedureIterator procIter)
throws IOException {
throw new IOException("Failed to delete the WALProcedureStore migrated
proc wal directory " +
procWALDir);
}
+ store.stop(true);
Review comment:
Do not need to be in finally block. If there are errors we just fail the
start up of HMaster. If we pass abort = false then it will try to append a
trailer which will cause teh stop to hang there.
Of course, a better way maybe call store.stop(false) before we delete the
proc wal directory, but not a big deal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
