[
https://issues.apache.org/jira/browse/HBASE-23701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017467#comment-17017467
]
Josh Elser commented on HBASE-23701:
------------------------------------
[~busbey] also asked a great question
[https://github.com/apache/hbase/pull/1052#discussion_r367200547] about why are
we only checking the first element of the Category annotation. I believe
compile-time checks enforce that we will only ever see a one-element array of
Category's for a class (certainly, given how we use it, that will be the case).
Let me also fix both the Test Rule and the Test Rule Checker to fail if we get
more than one to confirm that this is true, and prevent any surprises down the
road.
> Make sure HBaseClassTestRule doesn't suffer same issue as
> HBaseClassTestRuleChecker
> -----------------------------------------------------------------------------------
>
> Key: HBASE-23701
> URL: https://issues.apache.org/jira/browse/HBASE-23701
> Project: HBase
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
>
> [~bharathv] pointed out on HBASE-23695
> ([https://github.com/apache/hbase/pull/1052]) that HBaseClassTestRule suffers
> the same potential bug that I fixed in HBASE-23695 for
> HBaseClassTestRuleChecker. Make sure the fix is in both places.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
