saintstack commented on a change in pull request #1055: HBASE-23699 ByteBuff
may not recycle correctly when NettyRpcServer enabled and client disconnect
URL: https://github.com/apache/hbase/pull/1055#discussion_r368166024
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerResponseEncoder.java
##########
@@ -44,7 +44,6 @@ public void write(ChannelHandlerContext ctx, Object msg,
ChannelPromise promise)
RpcResponse resp = (RpcResponse) msg;
BufferChain buf = resp.getResponse();
ctx.write(Unpooled.wrappedBuffer(buf.getBuffers()),
promise).addListener(f -> {
- resp.done();
Review comment:
When is 'done' called or is it that we now defer to cleanup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
