petersomogyi commented on a change in pull request #1060: HBASE-23347 Allow
custom authentication methods for RPCs; addendum
URL: https://github.com/apache/hbase/pull/1060#discussion_r368216715
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/SaslClientAuthenticationProviders.java
##########
@@ -148,8 +150,9 @@ static void addExplicitProviders(Configuration conf,
// Instantiate it
SaslClientAuthenticationProvider provider;
try {
- provider = (SaslClientAuthenticationProvider) clz.newInstance();
- } catch (InstantiationException | IllegalAccessException e) {
+ provider = (SaslClientAuthenticationProvider)
clz.getConstructor().newInstance();
Review comment:
This modification causes
TestSaslClientAuthenticationProviders#testDifferentConflictingImplementationsFail
test failure. I'll look into it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
