saintstack commented on a change in pull request #1022: HBASE-23680
RegionProcedureStore missing cleaning of hfile archive
URL: https://github.com/apache/hbase/pull/1022#discussion_r368231529
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1520,8 +1518,10 @@ protected void stopServiceThreads() {
private void createProcedureExecutor() throws IOException {
MasterProcedureEnv procEnv = new MasterProcedureEnv(this);
- procedureStore =
- new RegionProcedureStore(this, new
MasterProcedureEnv.FsUtilsLeaseRecovery(this));
+ // Create cleaner thread pool
+ cleanerPool = new DirScanPool(conf);
Review comment:
I was thinking you'd call it up in the caller's method, in
startServiceThreads, rather than down hidden in here in
startProcedureExecutor... i.e. move the line up thee lines from where it was.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
