saintstack commented on a change in pull request #1075: HBASE-23645 Fixed
remaining Checkstyle violations in hbase-common tests
URL: https://github.com/apache/hbase/pull/1075#discussion_r368638361
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/TestTimeout.java
##########
@@ -18,31 +18,33 @@
package org.apache.hadoop.hbase;
import org.apache.hadoop.hbase.testclassification.SmallTests;
-import org.junit.Rule;
+
import org.junit.Ignore;
+import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.rules.TestRule;
-import org.junit.rules.Timeout;
@Category({SmallTests.class})
public class TestTimeout {
- @Rule public final TestRule timeout = CategoryBasedTimeout.builder()
+ @Rule
+ public final TestRule timeout = CategoryBasedTimeout.builder()
.withTimeout(this.getClass())
.withLookingForStuckThread(true)
.build();
- @Test
- public void run1() throws InterruptedException {
- Thread.sleep(100);
- }
+ @Test
+ public void run1() throws InterruptedException {
+ Thread.sleep(100);
+ }
- /**
- * Enable to check if timeout works.
- * Can't enable as it waits 30seconds and expected doesn't do Exception
catching
- */
- @Ignore @Test
- public void infiniteLoop() {
- while (true) {}
- }
+ /**
+ * Enable to check if timeout works.
+ * Can't enable as it waits 30seconds and expected doesn't do Exception
catching
+ */
+ @Ignore
+ @Test
+ public void infiniteLoop() {
Review comment:
I remember this one.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
