[
https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019876#comment-17019876
]
Bharath Vissapragada commented on HBASE-23647:
----------------------------------------------
[[email protected]] [~ndimiduk] [~stack] The patch is now ready for
review. It passes all the tests with MasterRegistry as default. Wanted to
quickly summarize the contents of the patch so that it is easier for you to
review.
- A recurring pattern that you see in the patch is trying to make connections
outlive cluster restarts. Normally they do but in case of the mini cluster they
don't because the master port numbers change after cluster restarts.
- The patch switches to ZKRegistry for a couple of cases (1) internal cluster
connections (RS <-> HMaster ) (2) communication between replication peers.
Backed up this with comments in the patch.
- The switch to MasterRegistry exposed a few flakes in the tests because the
connection establishment now is very quick unlike before where it took a few
seconds. A few tests were running into timing issues (races) because they were
written keeping the original latency in mind. Again, backed up with comments.
- Unit tests exposed a couple of minor bugs (one related to secure clusters
(kerberos) and other related to error case handling) in the master registry
implementation. Fixed both of them but nothing major.
Appreciate any feedback. Thanks.
> Make MasterRegistry the default registry impl
> ---------------------------------------------
>
> Key: HBASE-23647
> URL: https://issues.apache.org/jira/browse/HBASE-23647
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 3.0.0
> Reporter: Bharath Vissapragada
> Assignee: Bharath Vissapragada
> Priority: Major
>
> Now that we are close to getting the registry implementation patch in, the
> idea here is to make it the default implementation in 3.0.0 and this means
> - No known bugs with the implementation
> - No known performance issues
> - Entire nightly test suite is green (and without flakes).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
