[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253846#comment-13253846
 ] 

jirapos...@reviews.apache.org commented on HBASE-5621:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

This is the admin part of HBase-5443.  AdminProtocol part.


This addresses bug HBASE-5621.
    https://issues.apache.org/jira/browse/HBASE-5621


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/AdminProtocol.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/ClientProtocol.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 408db79 
  src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72 
  src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a 
  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 820e2a9 
  src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java fe80fcf 
  src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java 2a9d86e 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 3a3a79f 
  src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java b7afa58 
  src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java dd0a1bc 
  src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 9f159f2 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ab33ac7 
  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe 
  src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 422e865 
  src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 3d6a23a 
  src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830 
  src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a912cc3 
  src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java 
e78e56d 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0d22c0e 
  src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 9487a1c 
  
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
 04fe8b6 
  src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 61f8128 
  src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java ee4f556 
  src/main/protobuf/Admin.proto 132c5dd 
  src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java d6ae0e2 
  
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
 3cfc02b 
  src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 
8af0f91 
  src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b 
  src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 7dd60de 
  src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e 
  
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
 301ee27 
  src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java a59e152 
  src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 
b84a115 
  src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java cedf31e 
  src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java c0ac12c 
  
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
 d0cad45 
  src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a06942d 

Diff: https://reviews.apache.org/r/4714/diff


Testing
-------

All unit tests passed.


Thanks,

Jimmy


                
> Convert admin protocol of HRegionInterface to PB
> ------------------------------------------------
>
>                 Key: HBASE-5621
>                 URL: https://issues.apache.org/jira/browse/HBASE-5621
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to