[ https://issues.apache.org/jira/browse/HBASE-23683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022396#comment-17022396 ]
Sean Busbey commented on HBASE-23683: ------------------------------------- bq. It does change {{HBaseInterClusterReplicationEndpoint}} by adding two new protected methods, but that doesn't break compatibility. Adding protected methods does break source compatibility for a downstream user that creates their own {{HBaseInterClusterReplicationEndpoint}}. e.g. if they already had methods of the same signature defined but as a private method, or if they have the same name + args but a different return type. But since {{HBaseInterClusterReplicationEndpoint}} is marked {{IA.Private}} I think this is fine. > Make HBaseInterClusterReplicationEndpoint more extensible > --------------------------------------------------------- > > Key: HBASE-23683 > URL: https://issues.apache.org/jira/browse/HBASE-23683 > Project: HBase > Issue Type: Improvement > Components: Replication > Reporter: Wellington Chevreuil > Assignee: Wellington Chevreuil > Priority: Major > Fix For: 3.0.0, 2.3.0 > > > *HBaseInterClusterReplicationEndpoint* currently creates the cluster > connection and sink manager instances inside its _init_ method and assigns > those to private class variables. Then any potential custom extension of > *HBaseInterClusterReplicationEndpoint* that requires custom implementations > of connection and/or sink manager would need to resort to _java reflection_ > for effectively replace those instances, such as below: > {noformat} > ... > ClusterConnection conn = (ClusterConnection)ConnectionFactory. > createConnection(context.getConfiguration(), > User.create(replicationUgi)); > ReplicationSinkManager sinkManager = new ReplicationSinkManager(conn, > ctx.getPeerId(), > this, context.getConfiguration()); > try { > Field field = this.getClass().getSuperclass().getDeclaredField("conn"); > field.setAccessible(true); > field.set(this, conn); > field = > this.getClass().getSuperclass().getDeclaredField("replicationSinkMgr"); > field.setAccessible(true); > field.set(this, sinkManager); > } catch (Exception e) { > throw new IOException(e); > } > ... > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)