[ 
https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022609#comment-17022609
 ] 

Hudson commented on HBASE-23705:
--------------------------------

Results for branch branch-2
        [build #2425 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add CellComparator to HFileContext
> ----------------------------------
>
>                 Key: HBASE-23705
>                 URL: https://issues.apache.org/jira/browse/HBASE-23705
>             Project: HBase
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0
>
>
> The HFileContext is present when reading and writing files. It is populated 
> at read time using HFile trailer content and file metadata. At write time, we 
> create it up front.
> Interesting is that though CellComparator is written to the HFile trailer, 
> and parse of the Trailer creates an HFileInfo which builds the HFileContext 
> at read time, the HFileContext does not expose what CellComparator to use 
> decoding and seeking. Around the codebase there are various compensations 
> made for this lack with decoders that actually have a decoding context (with 
> a reference to the hfilecontext), hard-coding use of the default 
> CellComparator. StoreFileInfo will use default if not passed a comparator 
> (even though we'd just read the trailer and even though it has reference to 
> filecontext) and HFile does similar. What CellComparator to use in a given 
> context is confused.
> Let me fix this situation removing ambiguity. It will also fix bugs in parent 
> issue where UTs are failing because wrong CellComparator is being used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to