joshelser commented on a change in pull request #936: HBASE-17115 Define UI
admins via an ACL
URL: https://github.com/apache/hbase/pull/936#discussion_r370818099
##########
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java
##########
@@ -691,7 +703,6 @@ protected void addDefaultApps(ContextHandlerCollection
parent,
}
logContext.setDisplayName("logs");
setContextAttributes(logContext, conf);
- addNoCacheFilter(webAppContext);
Review comment:
We already do it globally on the WebAppContext. This just re-added the same
filter.
https://github.com/apache/hbase/blob/978546b2f247b29dd63bad55b17fdc2e7a31e55d/hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java#L642
Meant to leave a comment stating that but forgot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
