ndimiduk commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r370874480
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
##########
@@ -134,9 +140,9 @@ public LocalHBaseCluster(final Configuration conf, final
int noMasters,
*/
@SuppressWarnings("unchecked")
public LocalHBaseCluster(final Configuration conf, final int noMasters,
- final int noRegionServers, final Class<? extends HMaster> masterClass,
- final Class<? extends HRegionServer> regionServerClass)
- throws IOException {
+ final int noAlwaysStandByMasters, final int noRegionServers,
Review comment:
Ugh. The final constructor args are `Configuration, int, int, int, Class,
Class`. It's time for a builder with named arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
