ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371459518
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1251,6 +1258,9 @@ public RSRpcServices(final HRegionServer rs) throws
IOException {
ConnectionUtils.setServerSideHConnectionRetriesConfig(conf, name, LOG);
rpcServer = createRpcServer(rs, rpcSchedulerFactory, bindAddress, name);
rpcServer.setRsRpcServices(this);
+ if (!(rs instanceof HMaster)) {
+ rpcServer.setOnlineSlowLogProvider(rs.getOnlineSlowLogProvider());
Review comment:
Same comment as before re: using inheritance instead of instance inspection.
Wait, why must the logic be replicated here as well? Something smells...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
