ndimiduk commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r371497725
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java
##########
@@ -268,14 +268,19 @@ public static Configuration
createClusterConf(Configuration baseConf, String clu
* used to communicate with distant clusters
* @param conf configuration object to configure
* @param key string that contains the 3 required configuratins
- * @throws IOException
*/
private static void applyClusterKeyToConf(Configuration conf, String key)
- throws IOException{
+ throws IOException {
ZKConfig.ZKClusterKey zkClusterKey = ZKConfig.transformClusterKey(key);
conf.set(HConstants.ZOOKEEPER_QUORUM, zkClusterKey.getQuorumString());
conf.setInt(HConstants.ZOOKEEPER_CLIENT_PORT,
zkClusterKey.getClientPort());
conf.set(HConstants.ZOOKEEPER_ZNODE_PARENT, zkClusterKey.getZnodeParent());
+ // Without the right registry, the above configs are useless. Also, we
don't use setClass()
+ // here because the ConnectionRegistry* classes are not resolvable from
this module.
+ // This will be broken if ZkConnectionRegistry class gets renamed or
moved. Is there a better
+ // way?
Review comment:
> Overall, I think all MR jobs running on a single cluster will use master
registry. I think that answers the MR/Spark/Flink usecases.
Sounds good.
> I think these need to be rewritten with new config params like
hbase.[source|target].master.addrs for clients to pass the addresses so that
they can use master registry.
I think it's best to reduce the ZK-exposed surface area as much as possible.
This seems a reasonable solution to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
