[ 
https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024827#comment-17024827
 ] 

Viraj Jasani commented on HBASE-22775:
--------------------------------------

[~xucang] we can use {} for slf4j logging, otherwise the changes look good 
based on your recent explanation on why you want to put logs in 
ZKReplicationPeerStorage.

 

[~apurtell] hope, you are fine with this.

> Enhance logging for peer related operations
> -------------------------------------------
>
>                 Key: HBASE-22775
>                 URL: https://issues.apache.org/jira/browse/HBASE-22775
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xu Cang
>            Assignee: Xu Cang
>            Priority: Minor
>         Attachments: HBASE-22775.master.001.patch, 
> HBASE-22775.master.002.patch
>
>
> Now we don't have good logging regarding peer operations, for example addPeer 
> does not log itself:
> [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102]
> This Jira is aiming to enhancing this area



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to