bharathv commented on a change in pull request #1102: HBASE-23752: Fix 
remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r373321931
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
 ##########
 @@ -431,9 +431,13 @@ public static void setupCluster() throws Exception {
         UTIL.getDataTestDir("keytab").toUri().getPath());
     final MiniKdc kdc = UTIL.setupMiniKdc(KEYTAB_FILE);
 
-    // Switch back to NIO for now.
+    // Switch to blocking RPC impl.
     CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, 
BlockingRpcClient.class.getName());
     CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, 
SimpleRpcServer.class.getName());
+    // Set the connection registry to ZKConnectionRegistry since hedging is 
not supported on
+    // blocking rpc clients.
 
 Review comment:
   No worries, I parameterized it. Thanks for the quick response.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to