YamasakiSS commented on a change in pull request #951: HBASE-23578 [UI] Master
UI shows long stack traces when table is broken
URL: https://github.com/apache/hbase/pull/951#discussion_r373873763
##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -834,12 +844,19 @@ if (withReplica) {
</tbody>
</table>
<% }
-} catch(Exception ex) {
+} catch(Exception ex) { %>
+ Unknown Issue with Regions
+ <div
onclick="document.getElementById('closeRegion').style.display='block';document.getElementById('openRegion').style.display='none';">
+ <a id="openRegion" style="cursor:pointer;"> Show StackTrace</a>
+ </div>
+ <div id="closeRegion" style="display:none;clear:both;">
+ <div
onclick="document.getElementById('closeRegion').style.display='none';document.getElementById('openRegion').style.display='block';">
+ <a style="cursor:pointer;"> Close StackTrace</a>
+ </div>
+ <%
for(StackTraceElement element : ex.getStackTrace()) {
- %><%= StringEscapeUtils.escapeHtml4(element.toString()) %><%
+ %><%= StringEscapeUtils.escapeHtml4(element.toString() + "\n") %><%
}
-} finally {
Review comment:
Previous commit was conflicted in code of the finally section.
The HBASE-23653 removed the section and closed connection by changing
hbase-server/src/test/java/org/apache/hadoop/hbase/ConnectionRule.java.
I thought I should keep compatibility with the HBASE-23653.
How should I modify the code intentionally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
