belugabehr commented on a change in pull request #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#discussion_r375861045
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ########## @@ -72,8 +73,8 @@ private final int maxRetriesMultiplier; private final boolean eofAutoRecovery; - //Indicates whether this particular worker is running - private boolean isReaderRunning = true; + // Indicates whether this particular worker is running + private final AtomicBoolean isReaderRunning = new AtomicBoolean(true); Review comment: The volatile keyword is a fickle thing and this is not time-sensitive code. More straight forward to use the Java concurrent package ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
