busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r375602739
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobConstants.java
##########
@@ -63,40 +125,23 @@
* be merged in mob compaction. The default value is 1280MB.
*/
public static final String MOB_COMPACTION_MERGEABLE_THRESHOLD =
- "hbase.mob.compaction.mergeable.threshold";
+ "hbase.mob.compaction.mergeable.threshold";
public static final long DEFAULT_MOB_COMPACTION_MERGEABLE_THRESHOLD = 10 *
128 * 1024 * 1024;
- /**
- * The max number of del files that is allowed in the mob file compaction.
In the mob
- * compaction, when the number of existing del files is larger than this
value, they are merged
- * until number of del files is not larger this value. The default value is
3.
- */
public static final String MOB_DELFILE_MAX_COUNT =
"hbase.mob.delfile.max.count";
public static final int DEFAULT_MOB_DELFILE_MAX_COUNT = 3;
/**
- * The max number of the mob files that is allowed in a batch of the mob
compaction.
- * The mob compaction merges the small mob files to bigger ones. If the
number of the
- * small files is very large, it could lead to a "too many opened file
handlers" in the merge.
- * And the merge has to be split into batches. This value limits the number
of mob files
- * that are selected in a batch of the mob compaction. The default value is
100.
+ * The max number of the mob files that is allowed in a batch of the mob
compaction. The mob
+ * compaction merges the small mob files to bigger ones. If the number of
the small files is very
+ * large, it could lead to a "too many opened file handlers" in the merge.
And the merge has to be
+ * split into batches. This value limits the number of mob files that are
selected in a batch of
+ * the mob compaction. The default value is 100. Default is 0 - means no
limit - all regions of a
+ * MOB table will be compacted at once
*/
- public static final String MOB_COMPACTION_BATCH_SIZE =
- "hbase.mob.compaction.batch.size";
+ public static final String MOB_COMPACTION_BATCH_SIZE =
"hbase.mob.compaction.batch.size";
public static final int DEFAULT_MOB_COMPACTION_BATCH_SIZE = 100;
- /**
- * The period that MobCompactionChore runs. The unit is second.
- * The default value is one week.
- */
- public static final String MOB_COMPACTION_CHORE_PERIOD =
- "hbase.mob.compaction.chore.period";
- public static final int DEFAULT_MOB_COMPACTION_CHORE_PERIOD =
- 24 * 60 * 60 * 7; // a week
- public static final String MOB_COMPACTOR_CLASS_KEY =
"hbase.mob.compactor.class";
- /**
- * The max number of threads used in MobCompactor.
- */
- public static final String MOB_COMPACTION_THREADS_MAX =
- "hbase.mob.compaction.threads.max";
+ public static final String MOB_COMPACTION_THREADS_MAX =
"hbase.mob.compaction.threads.max";
Review comment:
should get removed from `hbase-common/src/main/resources/hbase-default.xml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
