ndimiduk commented on a change in pull request #1137: HBASE-23804: Fix default
master addr hostname in master registry
URL: https://github.com/apache/hbase/pull/1137#discussion_r376626826
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java
##########
@@ -66,4 +68,24 @@ public static String getDefaultHost(String strInterface,
String nameserver)
return org.apache.hadoop.net.DNS.getDefaultHost(strInterface,
nameserver);
}
}
+
+ /**
+ * Get the configured hostname for master/regionserver. Gets the default
hostname if not specified
+ * in the configuration.
+ * @param conf Configuration to look up.
+ * @param isMaster True if master hostname needs to be looked up and false
for regionserver.
+ */
+ public static String getHostname(Configuration conf, boolean isMaster)
Review comment:
This method has a number of commits sprinkled into its recent history:
HBASE-12954, HBASE-12956, HBASE-13481. They appear related to property binding
to `0.0.0.0` and to a configuration with multiple IP's on a network interface.
How do we test changes in this part of our code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
