esteban commented on a change in pull request #1138: HBASE-22827 Expose
multi-region merge in shell and Admin API
URL: https://github.com/apache/hbase/pull/1138#discussion_r376638342
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -535,14 +535,20 @@ def move(encoded_region_name, server = nil)
end
#----------------------------------------------------------------------------------------------
- # Merge two regions
- def merge_region(region_a_name, region_b_name, force)
- @admin.mergeRegionsAsync(
- region_a_name.to_java_bytes,
- region_b_name.to_java_bytes,
- java.lang.Boolean.valueOf(force)
+ # Merge multiple regions
+ def merge_region(regions = [], force)
Review comment:
Can we add support for the previous syntax? and not just when an array is
used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
