saintstack commented on a change in pull request #1158: HBASE-23823 Run maven with more than default single thread (--threads… URL: https://github.com/apache/hbase/pull/1158#discussion_r377292283
########## File path: dev-support/hbase-personality.sh ########## @@ -140,7 +140,11 @@ function personality_modules clear_personality_queue - extra="-DHBasePatchProcess" + # Pass maven a -T argument. Should make it run faster. Pass conservative value. + # Default is one thread. 0.5C on an apache box of 24 cores and 2 executors should + # make for 6 threads? Lets see. See below for more on -T: Review comment: 0.5 * 12 = 6. Let me change the title. It doesn't agree w/ what is in the patch which is trying to keep us close to current settings. Thanks @busbey ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
