ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r378419287
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1519,6 +1519,15 @@
"hbase.master.executor.logreplayops.threads";
public static final int MASTER_LOG_REPLAY_OPS_THREADS_DEFAULT = 10;
+ public static final String SLOW_LOG_RING_BUFFER_SIZE =
Review comment:
Yes, but adding fields here in `HConstants`, part of our public api, makes
maintaining these things more painful. I thought we had some developer guidance
around this, but I'm not finding it at the moment. Maybe someone else here
remembers those details.
I actually prefer that tests not use these contestants at all, but rather
write out the full configuration string values. That way it's easier to notice
when you accidentally break part of your public interface -- your tests that
depend on that interface start to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
