saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase URL: https://github.com/apache/hbase/pull/1165#discussion_r378447342
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ########## @@ -382,7 +386,7 @@ public void run() { private final LockManager lockManager = new LockManager(this); - private LoadBalancer balancer; + private RSGroupBasedLoadBalancer balancer; Review comment: This balancer acts like old balancer when RSGroups is off? If so, just rename RSGroupBasedLB as LB? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services