ndimiduk commented on issue #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#issuecomment-585372373
 
 
   > 2\. IMHO if we are going to achieve significant resource utilization with 
TTL of ring buffer entries, we can have a sub-task to this Jira, but do we 
really need it? I feel it's fine to let them stay in the buffer. Anyways size 
of the buffer and whether to even use ring buffer is up-to user. However, if 
required, I am fine with a sub-task.
   
   It is a fixed size of memory, and a relatively small amount, so I guess it's 
not a big deal. I just thought it would be good to free memory when we can. I 
see why this would be a bit of a hassle -- you'd need a cleaner chore and the 
Disruptor API is probably not designed for ad-hoc removal. I guess just omit it 
for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to