markrmiller commented on a change in pull request #1120: HBASE-23787:
TestSyncTimeRangeTracker fails quite easily and allocate…
URL: https://github.com/apache/hbase/pull/1120#discussion_r378482606
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSyncTimeRangeTracker.java
##########
@@ -84,23 +86,23 @@ public void run() {
assertTrue(trr.getMin() == 0);
}
- static class RandomTestData {
- private long[] keys = new long[NUM_KEYS];
- private long min = Long.MAX_VALUE;
- private long max = 0;
+ static class RandomTestData {
+ private final AtomicLongArray keys = new AtomicLongArray(NUM_KEYS);
+ private long min = Long.MAX_VALUE; // effectively final
+ private long max = 0; // effectively final
Review comment:
Right, would be ideal to make them final, settling for marking them
effectively final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
