[ 
https://issues.apache.org/jira/browse/HBASE-21902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036454#comment-17036454
 ] 

david zhang commented on HBASE-21902:
-------------------------------------

IIRC throwing the RuntimeException just exposes the test passes 
(false-negative).  It isn't intended as a fix.  I can provide a fix if you'd 
like, I recall fixing this in my own branch. Just give me sometime to jog my 
memory.

thanks for the comment Xu Cang.

> TestCompactionWithCoprocessor doesn't invoke coprocessor logic
> --------------------------------------------------------------
>
>                 Key: HBASE-21902
>                 URL: https://issues.apache.org/jira/browse/HBASE-21902
>             Project: HBase
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.0.4
>            Reporter: david zhang
>            Priority: Minor
>         Attachments: hbase-test.patch
>
>
> TestCompactionWithCoprocessor is designed to invoke NoOpScanPolicyObserver 
> which implements default behavior.  in reality NoOpScanPolicyObserver isn't 
> instantiated, TestCompactionWithCoprocessor runs/passes trivially, without 
> increasing test coverage beyond TestCompaction.
> See patch which passes TestCompactionWithCoprocessor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to