virajjasani edited a comment on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-586575972 Using thread-safe wrapper over EvictingQueue makes life simpler, however it does not have any perf improvement because earlier I was using lock to write data in array in thread safe manner (tested both with same load where both approach took ~20-22 s to complete). However, using it has good advantages over not losing any writes specifically if manual locks time out or get InterruptedException, and of course less manual code to maintain. Thanks @bharathv for the suggestion.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
