[ 
https://issues.apache.org/jira/browse/HBASE-23853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038496#comment-17038496
 ] 

Michael Stack commented on HBASE-23853:
---------------------------------------

Just pushed new addendum:
{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
index dfce7914bc..be4c31f2b0 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
@@ -131,7 +131,7 @@ public class CacheConfig {
   private boolean cacheBloomsOnWrite;

   /** Whether blocks of a file should be evicted when the file is closed */
-  private boolean evictOnClose;
+  private volatile boolean evictOnClose;
{code}

See if this helps.

After studying test more, looks like there is a bug in here. Lets see.

> [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits
> ----------------------------------------------------------------------
>
>                 Key: HBASE-23853
>                 URL: https://issues.apache.org/jira/browse/HBASE-23853
>             Project: HBase
>          Issue Type: Bug
>          Components: flakies
>            Reporter: Michael Stack
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0
>
>         Attachments: 
> 0001-HBASE-23853-Flakey-Test-TestBlockEvictionFromClient-.patch, Screen Shot 
> 2020-02-15 at 2.36.47 PM.png
>
>
> Fails 12-25% of the time in the GCE build.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to