Apache9 commented on a change in pull request #1182: HBASE-23864 No need to 
submit SplitTableRegionProcedure/MergeTableReg…
URL: https://github.com/apache/hbase/pull/1182#discussion_r380532313
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
 ##########
 @@ -453,13 +453,6 @@ private boolean prepareMergeRegion(final 
MasterProcedureEnv env) throws IOExcept
       throw new MergeRegionException("Skip merging regions " +
           RegionInfo.getShortNameToLog(regionsToMerge) + ", because we are 
snapshotting " + tn);
     }
-    if 
(!env.getMasterServices().isSplitOrMergeEnabled(MasterSwitchType.MERGE)) {
 
 Review comment:
   But split and merge can be scheduled by background task? And also, if you 
remove the checks here, then you need to add the check everywhere...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to