[ 
https://issues.apache.org/jira/browse/HBASE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254841#comment-13254841
 ] 

Zhihong Yu commented on HBASE-5733:
-----------------------------------

Minor comment:
Similar sentence appears 3 times below:
{code}
+      LOG.fatal("Problem in getting the children from ZK. Going to abort");
+      master.abort("Problem in getting the children from ZK", new IOException(
+          "Failed to get the children from ZK"));
+      return;
{code}
Can "Failed to get the children from ZK" be shared ?
                
> AssignmentManager#processDeadServersAndRegionsInTransition can fail with NPE.
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-5733
>                 URL: https://issues.apache.org/jira/browse/HBASE-5733
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HBASE-5733.patch
>
>
> Found while going through the code...
> AssignmentManager#processDeadServersAndRegionsInTransition can fail with NPE 
> as this is directly iterating the nodes from 
> listChildrenAndWatchForNewChildren with-out checking for null.
> Here also we need to handle with  null  check like other places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to