bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382232200
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -590,6 +596,10 @@ public HRegionServer(final Configuration conf) throws
IOException {
this.abortRequested = false;
this.stopped = false;
+ // initiate online slowlog ringbuffer only for RegionServers
+ if (!(this instanceof HMaster)) {
Review comment:
I think Nick had a valid point..didn't get your response..why not check conf
for "hbase.regionserver.slowlog.buffer.enabled" and not initialize
SlowLogRecorder? You have checks anyway in the callers like
if (slowLogRecorder!= null) slowLogRecorder.addPayLoad()...
I think that simplies the code rather than having conditionals in
SLowLogRecorder constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
