ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r382868840
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
-
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+ YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
Okay, this was a bit of learning out loud.
My longer-term goal is to converge the Jenkinsfiles/Dockerfiles across
branches. Thus the image will ship with multiple JDKs and the jobs will need to
manage `JAVA_HOME` the Jenkinsfile instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
