[
https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043196#comment-17043196
]
kangkang.guo commented on HBASE-23669:
--------------------------------------
[~stack] Thanks for the review. Yes, I think it still needs to be fixed,
because this is the error that occurred when the master deleted its
corresponding znode when exiting, regardless of whether there was any region on
the master
> ZNodeClearer#clear() throws IllegalArgumentException
> -----------------------------------------------------
>
> Key: HBASE-23669
> URL: https://issues.apache.org/jira/browse/HBASE-23669
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.1.5
> Reporter: kangkang.guo
> Assignee: kangkang.guo
> Priority: Major
> Fix For: 2.1.5, 2.1.6, 2.1.8
>
> Attachments: HBASE-23669.branch-2.1.0001.patch,
> HBASE-23669.master.patch
>
>
> Precondition:
> hbase.balancer.tablesOnMaster = true
> hbase.balancer.tablesOnMaster.systemTablesOnly = true
> In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by
> regionserver process in HRegionServer#handleReportForDutyResponse() here is
> how it looks on master server:
> [hadoop@master-node data]$ cat hbase-hadoop-master.znode
> /hbase/rs/master-node,16000,1578371505720
> When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of
> the file, causing an exception：
> java.lang.IllegalArgumentException: Invalid path string
> "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node
> name specified @10
> at
> org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99)
> at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251)
> at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
