petersomogyi commented on a change in pull request #1198: HBASE-23740 Invalid 
StoreFile WARN log message printed for recovered.…
URL: https://github.com/apache/hbase/pull/1198#discussion_r383138353
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
 ##########
 @@ -278,7 +282,11 @@ public String getStoragePolicyName(String familyName) {
     List<LocatedFileStatus> validStoreFiles = Lists.newArrayList();
     for (LocatedFileStatus status : locatedFileStatuses) {
       if (validate && !StoreFileInfo.isValid(status)) {
-        LOG.warn("Invalid StoreFile: " + status.getPath());
+        // recovered.hfiles directory is expected inside CF path when 
hbase.wal.split.to.hfile to
+        // true, refer HBASE-23740
+        if 
(!HConstants.RECOVERED_HFILES_DIR.equals(status.getPath().getName())) {
+          LOG.warn("Invalid StoreFile: " + status.getPath());
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to