ndimiduk commented on a change in pull request #1173: HBASE-23851 Log networks 
and bind addresses when multicast publisher/…
URL: https://github.com/apache/hbase/pull/1173#discussion_r383450855
 
 

 ##########
 File path: 
hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
 ##########
 @@ -373,7 +373,7 @@ protected synchronized void cleanup() {
   @InterfaceAudience.Private
   @Override
   public String toString() {
-    return "[ScheduledChore: Name: " + getName() + " Period: " + getPeriod() + 
" Unit: "
-        + getTimeUnit() + "]";
+    return "ScheduledChore name=" + getName() + ", period=" + getPeriod() +
 
 Review comment:
   If you're going to tweak `toString()` methods, you mind converting over use 
Commons's `ToStringBuilder` with the `ShortPrefixToStringStyle` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to